jackbenny/check_domain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
17 Commits 1 Branch 0 Tags
01a20073369dad2e528fed191b61c2eeae3b0af9
Commit Graph
17 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jackbenny 01a2007336 Added support for .net TLD 2013-11-28 23:22:05 +01:00
Ryan Loudfoot 5f79f0f9f3 Updated as per Vidar from shellcheck.net. 
Email received from Vidar:
Hi,

On line 53 in the script, getopt is used with -u:

 -u, --unquoted
     Do not quote  the  output.  Note  that  whitespace  and  special
     (shell-dependent)  characters can cause havoc in this mode (like
     they do with other getopt(1) implementations).

This havoc is basically what Shellcheck is warning about.

Unfortunately it's not simply a matter of quoting the variable, since the
underlying problem is the way getopt is used.

Instead of -u, you can use -s bash, and then eval instead of word split:

args=$(getopt -o hd:w:c:P: --long help,domain:,warning:,critical:,path: -s
bash -n "$PROGRAM" -- "$@")
...
eval "set -- $args"

This way, no havoc is caused, and no shellcheck errors are reported.

Regards,
Vidar
 2013-11-03 18:11:48 -05:00
Ryan Loudfoot c6471330d6 Update my (Ryan) email address and fix utils.sh check (-a deprecated, using -e now) 2013-11-02 12:19:10 -04:00
Ryan Loudfoot 8358bd7f09 One pass through spellcheck.net. Hiccup on line: set -- 2013-11-02 11:14:27 -04:00
Elyrith 0999905ff0 Use GoDaddy whois for .ca now. 2013-10-02 20:13:31 -04:00
Elyrith 58e813d162 Lower-case readme file name and add changelog to it. 2013-09-06 19:30:22 -04:00
Elyrith e46bb45634 Loudfoot.com whois info no longer necessary with new .com method. 2013-09-06 19:18:17 -04:00
Elyrith b3a65ef141 Version 0.92 - New .com method which works for more domains. 2013-09-06 19:17:49 -04:00
Elyrith 783be8a36a Add example of a .com that check_domain doesn't work for. 2013-08-24 23:34:01 -04:00
Elyrith 23adc98cdc Add check for utils.sh. See note on line 33. 2013-08-23 17:08:06 -04:00
Elyrith 59a503a218 Changed to numbering versions. 2013-08-22 22:11:19 -04:00
Elyrith 595c3cc03b Add nagios exit state constants 2013-08-22 22:10:09 -04:00
Elyrith 2df597f8df Not sure when, but all the output lines got commented out. Fixed. 2013-08-21 23:44:26 -04:00
Elyrith f84ac3e093 Ubuntu whois broke .com checks. This fixes it by searching for a different string. 2013-08-20 17:26:52 -04:00
Elyrith d205948548 Update README with info about requesting more TLDs 2013-08-09 18:16:43 -04:00
Elyrith 9fd6774670 General maintenance. Create README, update repo URL, etc. 2013-06-04 17:56:05 -04:00
Elyrith bb78e81d15 Move from Bitbucket to GitHub 2013-06-04 17:09:35 -04:00